On 2/5/25 4:52 PM, Krzysztof Kozlowski wrote:

quoted

+static const struct acpm_handle *acpm_get_by_phandle(struct device *dev)

"by_phandle" takes the name of the property with phandle as an argument,
because otherwise you do not have here phandle part at all in the
interface (see syscon API).

Indeed.

Other option would be by actual phandle - see of_find_node_by_phandle().

I would propose in such case only acpm_get() or maybe better of_acpm_get()?

quoted

+{

cut

quoted

+	np = of_parse_phandle(dev->of_node, "exynos,acpm_ipc", 0);

You need bindings for this somewhere and fix the underscore->hyphen...
and vendor prefix. It really would not be accepted that way so please
post consumer bindings anywhere.

There's no consumer upstreamed yet, I don't know where I shall specify
it. How about keeping the function name and modify the declaration to

+static const struct acpm_handle *acpm_get_by_phandle(struct device_node
*np,
+						     const char *property)

This shall be in line with the syscon API and doesn't force me to
introduce bindings for the consumers now.

Thanks!
ta