Re: [PATCH net-next v4 25/27] dt-bindings: net: pse-pd: microchip,pd692x0: Add manager regulator supply
flat view
From: Kory Maincent <kory.maincent@bootlin.com>
Date: 2025-02-05 14:05:47
Also in:
linux-doc, lkml, netdev
Hello Krzysztof, On Sat, 4 Jan 2025 10:52:55 +0100 Krzysztof Kozlowski [off-list ref] wrote:
On Fri, Jan 03, 2025 at 10:13:14PM +0100, Kory Maincent wrote:quoted
From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com> This patch adds the regulator supply parameter of the managers.quoted
+ vmain-supply: + description: Regulator power supply for the PD69208X manager.s/Regulator// Keep it simple, no need to state obvious. What is not obvious here is why there are no main device supplies (VDD, VDDA). And what about VAUX5 and VAUX3P3? So basically the description is not only redundant but actually incorrect because it suggests it is entire supply, while there are others.
VMAIN can be the only power supply, with VAUX5 and VAUX3P3 derived internally from VMAIN. However having the descriptions of all the regulator supplies is indeed maybe better. I will update the patch accordingly. Regards, -- Köry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com