Re: [PATCH v5 4/5] arm64: dts: agilex: add dts enabling PCIe Root Port
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-02-05 07:32:25
Also in:
linux-pci, lkml
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-02-05 07:32:25
Also in:
linux-pci, lkml
On 04/02/2025 17:57, matthew.gerlach@linux.intel.com wrote:
quoted
quoted
quoted
quoted
+#include "socfpga_agilex_pcie_root_port.dtsi" +Missing board compatible, missing bindings.The model and compatible bindings are inherited from socfpga_agilex_socdk.dts.Then this is the same board, so entire DTS should be removed and instead merged into parent DTS. There is no such thing as "inherit" of an compatible.It is the same physical board, but the image programmed into the FPGA is different in so far as the PCIe IP is connected and enabled. This different FPGA image allows for a PCIe End Point to be plugged in. Is this difference enough for it be considered and different board?
Yes, it can be different board DTS. Look at other vendors how shared designs are being actually shared between DTS - DTSI. Best regards, Krzysztof