Re: [PATCH v3 05/10] ARM: dts: aspeed: system1: Add RGMII support

From
Andrew Lunn <andrew@lunn.ch>
Date
2025-01-08 20:14:29
Also in
linux-arm-kernel, linux-aspeed, lkml, netdev
Reply to
Ninad Palsule, 2025-01-08
On Wed, Jan 08, 2025 at 12:43:07PM -0600, Ninad Palsule wrote:
Hello Andrew,


On 1/8/25 11:03, Andrew Lunn wrote:
quoted
On Wed, Jan 08, 2025 at 10:36:33AM -0600, Ninad Palsule wrote:
quoted
system1 has 2 transceiver connected through the RGMII interfaces. Added
device tree entry to enable RGMII support.

ASPEED AST2600 documentation recommends using 'rgmii-rxid' as a
'phy-mode' for mac0 and mac1 to enable the RX interface delay from the
PHY chip.
You appear to if ignored my comment. Please don't do that. If you have
no idea about RGMII delays, please say so, so i can help you debug
what is wrong.

NACK
I think there is a misunderstanding. I did not ignore your comment. I have
contacted ASPEED and asked them to respond. I think Jacky from Aspeed
replied to your mail.
You did not mention in the cover letter, or the patch. I asked for a
detailed explanation in the commit message why it is correct, which
you did not do.

Now we have more details, it is clear Ethernet support for this board
needs to wait until we figure out how to fix the MAC driver. Please
either wait with this patchset until that is done, or drop this one
patch for the moment and submit it later once the MAC driver is fixed.

      Andrew
Thread (27 messages) 27 messages, 4 authors, last reply 2025-01-14
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help