Thread (7 messages) 7 messages, 3 authors, 2024-12-10

Re: [PATCH v4 2/2] dt-bindings: input: Add Nuvoton MA35D1 keypad

From: Ming-Jen Chen <hidden>
Date: 2024-12-10 05:23:44
Also in: linux-arm-kernel, linux-input, lkml


On 2024/12/4 下午 03:49, Krzysztof Kozlowski wrote:
On Wed, Dec 04, 2024 at 02:10:14AM +0000, Ming-Jen Chen wrote:
quoted
Add YAML bindings for MA35D1 SoC keypad.

Signed-off-by: Ming-Jen Chen <redacted>

Repeating same comment third or fourth time is a waste of my time.

NAK.

It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.

Best regards,
Krzysztof
I will carefully review the v3 discussion thread to ensure that all
feedback is properly implemented. Once I’ve addressed the issues, I’d
like to confirm the next steps with you:

1. Should I drop v4 entirely and submit a revised patch as v5?
2. Alternatively, would you prefer me to resend v4 with the necessary
corrections?

Please let me know your preference so I can proceed accordingly and
ensure a smoother review process.

Thank you again for your guidance and understanding.

Best regards,
Ming-Jen Chen



Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help