Re: [PATCH v3 10/10] ARM: dts: ti: omap: samsung-espresso10: Add initial support for Galaxy Tab 2 10.1
From: Andreas Kemnade <andreas@kemnade.info>
Date: 2024-11-23 19:02:20
Also in:
dri-devel, linux-hardening, linux-omap, lkml
Am Sat, 23 Nov 2024 17:52:58 +0000 schrieb Mithil Bavishi [off-list ref]:
quoted
quoted
+&i2c3 { + touchscreen: synaptics-rmi4-i2c@20 {touchscreen@20Fixed, generic node names right!quoted
quoted
+ avdd-supply = <®_touch_ldo_en>;not known in schemaI cannot seem to find the "vio-supply" shown in the bindings. There is only mention of avdd-supply and vdd-supply. I am not sure if avdd and vio are equivalent, hence the confusion. What should be the solution here?
well, look at the schematics and see how it is wired ;-) Without schematic, it is a bit tricky. So you can look how it is used. vdd-supply sounds like something to make the chip fully functional. vio-supply seems to be for the io lines. As the vendor kernel seem to set i2c to gpio mode, so probably because the vio-supply is powered down according to the board file you posted. So it might be vio-supply only or vio and vdd-supply combined. In any case document what you have seen in the vendor kernel.
quoted
Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml: horizontal resolution of touchscreen (maximum x coordinate reported + 1)quoted
So this touchscreen reports max 1278?Fixed it as well, 1280 and 800 respectively. https://github.com/Unlegacy-Android/android_kernel_ti_omap4/blob/3.4/common/arch/arm/mach-omap2/board-espresso-input.c#L264quoted
And these things belong below rm4-f11 according to Documentation/devicetree/bindings/input/syna,rmi4.yamlI did not quite understand what you mean by this. I checked the bindings and a few examples, there is nothing "below" rmi4-f11.
this part of the binding description
patternProperties:
"^rmi4-f1[12]@1[12]$":
type: object
unevaluatedProperties: false
$ref: /schemas/input/touchscreen/touchscreen.yaml#
description:
basically says that standard touchscreen properties are accepted below
rmi4-f11.
In the example you have:
rmi4-f11@11 {
reg = <0x11>;
touchscreen-inverted-y;
syna,sensor-type = <2>;
};
Regards,
Andreas