Re: [PATCH v2 2/9] dt-bindings: x86: Add a binding for x86 wakeup mailbox

From
Krzysztof Kozlowski <krzk@kernel.org>
Date
2024-09-20 11:19:34
Also in
linux-acpi, linux-hyperv, lkml
Reply to
Yunhong Jiang, 2024-09-19
On 20/09/2024 00:15, Yunhong Jiang wrote:
quoted
quoted
quoted
For your "validated by the tools", can you please share the tools you used to
validate the schema? I used "make dt_binding_check" per the
submitting-patches.rst but I think your comments is about another tool.
See writing-schema document.
Yes, I figured out in the end that the validate tools means the dt-schema tools.

Thank you
--jyh
One thing just come to my mind. The
Documentation/devicetree/bindings/x86/wakeup.yaml only adds one property,
wakeup-mailbox-addr, to the cpus node, and it does not specify any new object.
Per my understanding, the json schema file normally specifies a new object.
Is my change a supported scenario in current Documentation/devicetree?
I think that's not related. You can add properties per specific devices,
but (as I said) you do not have a compatible. Compatible represents a
specific device. You do not have it. Look at the cpus.yaml schema.
I checked similar scenario like arm/cpu-enable-method/nuvoton and
npcm750-smp/cpu-enable-method/al,alpine-smp, they don't present as a json
schema file. Wonder if it's because the same reason.
Rather no one cares about that hardware.


Best regards,
Krzysztof
Thread (33 messages) 33 messages, 5 authors, last reply 2025-03-20
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help