Thread (10 messages) 10 messages, 3 authors, 2024-08-29

Re: [PATCH v4 2/5] Coresight: Add trace_id function to retrieving the trace ID

From: Markus Elfring <hidden>
Date: 2024-08-28 17:51:17
Also in: linux-arm-kernel, linux-arm-msm, lkml

quoted hunk ↗ jump to hunk
+++ b/drivers/hwtracing/coresight/coresight-sysfs.c
@@ -168,6 +168,7 @@ int coresight_enable_sysfs(struct coresight_device *csdev)
 	int cpu, ret = 0;
 	struct coresight_device *sink;
 	struct list_head *path;
+	struct cs_sink_data *sink_data;
…

* How do you think about to use the attribute “__free(kfree)” at more places accordingly?
  https://elixir.bootlin.com/linux/v6.11-rc5/source/include/linux/slab.h#L282

* Would you like to reduce the scope for such a local variable?


Regards,
Markus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help