Thread (99 messages) 99 messages, 8 authors, 2024-10-08

Re: [PATCH 13/13] media: qcom: camss: Add support for VFE hardware version Titan 780

From: Depeng Shao <hidden>
Date: 2024-08-15 14:24:37
Also in: linux-arm-msm, linux-media, lkml

Hi Bryan,
quoted
+
+static inline void vfe_reg_update_clear(struct vfe_device *vfe,
+                    enum vfe_line_id line_id)
+{
+    int port_id = line_id;
+
+    /* RUP(register update) registers has beem moved to CSID in Titan 
780.
+     * Notify the event of trigger RUP clear.
+     */
+    camss_reg_update(vfe->camss, vfe->id, port_id, true);
+}
Hmm, so another thought here.

camss_reg_update() is not an accurate name -> camss_rup_update() because 
in this case we only update the RUP register, not the AUP or MUP.

reg is an abbreviation for register - but RUP has a defined meaning in 
the camera namespace i.e. RUP = register update and its job is to latch 
shadow registers to real registers.

camss_rup_update() please.
Yes, you are right, the rup_update is reasonable, I will update it in 
next version patch.

Thanks,
Depeng
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help