Re: [PATCH v3 1/7] dt-bindings: connector: add GE SUNH hotplug addon connector

From
Luca Ceresoli <luca.ceresoli@bootlin.com>
Date
2024-08-14 14:42:49
Also in
dri-devel, linux-i2c, lkml
Reply to
Rob Herring, 2024-08-13
Hello Rob,

On Tue, 13 Aug 2024 09:19:01 -0600
Rob Herring [off-list ref] wrote:
On Fri, Aug 09, 2024 at 05:34:49PM +0200, Luca Ceresoli wrote:
quoted
Add bindings for the GE SUNH add-on connector. This is a physical,
hot-pluggable connector that allows to attach and detach at runtime an
add-on adding peripherals on non-discoverable busses.  
Overall, looks pretty good.
Thanks, I'm very glad it does.
quoted
+    maxItems: 1
+
+  nobus-devices:  
Just 'devices'.
Sure, simple enough.
quoted
+    description:
+      A container for devices not accessible via any data bus. Common use
+      cases include fixed and GPIO regulators, simple video panels and LED
+      or GPIO backlight devices. When not hot-pluggable, nodes such devices
+      are children of the root node.
+
+      This node should not be present in the connector description in the
+      base device tree. It should be added by overlays along with a subnode
+      per device.
+
+    type: object
+    additionalProperties: false  
The schema needs to work with the overlay applied too. 'true' is fine 
here.
Does additionalProperties apply to nodes as well? No properties are
supposed to be added inside this node, only nodes, so I'm not sure what
to do about additionalProperties.

Queued all other changes for v4.

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Thread (13 messages) 13 messages, 2 authors, last reply 2024-08-14
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help