Thread (5 messages) 5 messages, 4 authors, 2024-08-09

Re: [PATCH] ARM: dts: Fix undocumented LM75 compatible nodes

From: Kevin Hilman <khilman@baylibre.com>
Date: 2024-08-08 22:40:29
Also in: imx, linux-arm-kernel, linux-aspeed, linux-omap, lkml, openbmc

"Rob Herring (Arm)" [off-list ref] writes:
"lm75" without any vendor is undocumented. It works with the Linux
kernel since the I2C subsystem will do matches of the compatible string
without a vendor prefix to the i2c_device_id and/or driver name.

Mostly replace "lm75" with "national,lm75" as that's the original part
vendor and the compatible which matches what "lm75" matched with. In a
couple of cases the node name or compatible gives a clue to the actual
part and vendor and a more specific compatible can be used. In these
cases, it does change the variant the kernel picks.

"nct75" is an OnSemi part which is compatible with TI TMP75C based on
a comparison of the OnSemi NCT75 datasheet and configuration the Linux
driver uses. Adding an OnSemi compatible would be an ABI change.

"nxp,lm75" is most likely an NXP part. NXP makes a LM75A and LM75B.
Both are 11-bit resolution and 100ms sample time, so "national,lm75b" is
the closest match.

While we're here, fix the node names to use the generic name
"temperature-sensor".

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
SoC maintainers, Please take this directly.
[...]
 arch/arm/boot/dts/ti/omap/am335x-nano.dts     |  2 +-
For this one...

Reviewed-by: Kevin Hilman <khilman@baylibre.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help