Re: [PATCH v2 2/2] pmdomain: rockchip: Add support for rk3576 SoC
From: Heiko Stübner <heiko@sntech.de>
Date: 2024-08-08 16:41:32
Also in:
linux-arm-kernel, linux-pm, linux-rockchip, lkml
Hi Detlev, Am Donnerstag, 8. August 2024, 18:31:05 CEST schrieb Detlev Casanova:
quoted hunk ↗ jump to hunk
From: Finley Xiao <redacted> Add configuration for RK3576 SoC and list the power domains. Signed-off-by: Finley Xiao <redacted> [rebase, reword, squash] Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com> --- drivers/pmdomain/rockchip/pm-domains.c | 73 ++++++++++++++++++++++++-- 1 file changed, 70 insertions(+), 3 deletions(-)diff --git a/drivers/pmdomain/rockchip/pm-domains.c b/drivers/pmdomain/rockchip/pm-domains.c index 9b76b62869d0d..863f1ad6b9e11 100644 --- a/drivers/pmdomain/rockchip/pm-domains.c +++ b/drivers/pmdomain/rockchip/pm-domains.c
[...]
quoted hunk ↗ jump to hunk
@@ -175,6 +195,9 @@ struct rockchip_pmu { #define DOMAIN_RK3568(name, pwr, req, wakeup) \ DOMAIN_M(name, pwr, pwr, req, req, req, wakeup) +#define DOMAIN_RK3576(name, p_offset, pwr, status, r_status, r_offset, req, idle, g_mask, delay, wakeup) \ + DOMAIN_M_O_R_G(name, p_offset, pwr, status, r_status, r_offset, req, idle, idle, g_mask, delay, wakeup) + /* * Dynamic Memory Controller may need to coordinate with us -- see * rockchip_pmu_block().@@ -552,7 +575,10 @@ static int rockchip_pd_power(struct rockchip_pm_domain *pd, bool power_on) /* if powering up, leave idle mode */ rockchip_pmu_set_idle_request(pd, false); - rockchip_pmu_restore_qos(pd); + if (pd->info->delay_us) + udelay(pd->info->delay_us); + else + rockchip_pmu_restore_qos(pd);
I still want this behaviour change in a separate patch with adequate commit message please. Going from always handling qos to allowing to just wait a specific time needs explanation and is not part of "just" adding rk3576 support. Heiko