Re: [PATCH v7 2/3] dt-bindings: iio: proximity: Add TYHX HX9023S

From
Krzysztof Kozlowski <krzk@kernel.org>
Date
2024-06-25 05:48:58
Also in
linux-iio, lkml
Reply to
Yasin Lee, 2024-06-25
On 25/06/2024 04:15, Yasin Lee wrote:
A capacitive proximity sensor

Acked-by: Conor Dooley <conor@kernel.org>
Acked-by: Jonathan Cameron <jic23@kernel.org>
Acked-by: Krzysztof Kozlowski <redacted>
What? How did this happen? Where - provide lore links to prove it?

NAK
Reported-by: "Rob Herring (Arm)" [off-list ref]
No, drop.
Signed-off-by: Yasin Lee <redacted>
quoted hunk ↗ jump to hunk
+
+patternProperties:
+  "^channel@[0-4]$":
+    $ref: /schemas/iio/adc/adc.yaml
+    type: object
+
+    properties:
+      reg:
+        minimum: 0
+        maximum: 4
+        description: The channel number.
+
+      single-channel: true
+
+      diff-channels: true
+
+    oneOf:
+      - required:
+          - single-channel
+      - required:
+          - diff-channels
+
+    required:
+      - reg
... and now you should see that you duplicated adc.yaml. This should be
just:

+patternProperties:
+  "^channel@[0-4]$":
+    $ref: /schemas/iio/adc/adc.yaml
+    type: object
+    unevaluatedProperties: false
+
+    properties:
+      reg:
+        minimum: 0
+        maximum: 4
+        description: The channel number.



Best regards,
Krzysztof
Thread (18 messages) 18 messages, 6 authors, last reply 2024-08-02
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help