Re: [PATCH 00/23] Introduce irq_domain_instanciate()
From: Thomas Gleixner <hidden>
Date: 2024-06-17 13:57:46
Also in:
linux-um, lkml
Herve! On Fri, Jun 14 2024 at 19:32, Herve Codina wrote:
During the review, it was asked to rework the irq domain modification in order to avoid more wrappers and a new irq_domain_instanciate() function was proposed [2]. Also a patch [3] sent by Maitti Vaittinen can benefit of this new irq_domain_instanciate() function. Even if Maitti's use case is not handle yet in this series, it should not be a big deal add support for it on top of this current series. So, this current series introduces this new irq_domain_instanciate() function and migrate existing wrappers and functions to this new function (patches 1 to 20). It then introduces the first driver that uses directly this new function with the init()/exit() hooks set: the Microchip LAN966x OIC driver (patches 21 to 23). Existing irqchip drivers are not converted yet to use this new API function in the same way as the LAN966x OIC driver does. I prefer to have this series accepted first to avoid doing and re-doing several times the same modifications on existing drivers depending on changes requested on this current series review.
I'm truly impressed by the quality of this patch set.
The only nitpicks I found was the formatting of the struct
initializers. I fixed them up for you this time. Keep up the good work!
The result can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq/core
Matti, can you please build your extensions on top of that?
Thanks,
tglx