Re: [PATCH 2/3] devicetree: phy: rockchip-emmc: Document changed strobe-pulldown property
From: Conor Dooley <conor@kernel.org>
Date: 2024-03-26 19:35:00
Also in:
linux-arm-kernel, linux-phy, linux-rockchip, lkml
On Tue, Mar 26, 2024 at 07:54:36PM +0100, Folker Schwesinger via B4 Relay wrote:
From: Folker Schwesinger <redacted>
The prefix is "dt-bindings" not "devicetree" FYI.
Document the changes regarding the optional strobe-pulldown property. These changes are necessary as the default behavior of the driver was restored to the Rockchip kernel behavior of enabling the internal pulldown by default.
I don't think this is a valid justification, but it'll be easier for me to explain this on the driver patch. Thanks, Conor.
quoted hunk ↗ jump to hunk
Fixes: f34e43f12382 ("devicetree: phy: rockchip-emmc: pulldown property") Signed-off-by: Folker Schwesinger <redacted> --- Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt index 57d28c0d5696..10c05437f7ab 100644 --- a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt +++ b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt@@ -16,8 +16,8 @@ Optional properties: - drive-impedance-ohm: Specifies the drive impedance in Ohm. Possible values are 33, 40, 50, 66 and 100. If not set, the default value of 50 will be applied. - - rockchip,enable-strobe-pulldown: Enable internal pull-down for the strobe - line. If not set, pull-down is not used. + - rockchip,disable-strobe-pulldown: Disable internal pull-down for the strobe + line. If not set, pull-down is used. - rockchip,output-tapdelay-select: Specifies the phyctrl_otapdlysec register. If not set, the register defaults to 0x4. Maximum value 0xf.-- 2.44.0
Attachments
- signature.asc [application/pgp-signature] 228 bytes