Hi, Geert,

On 14.03.2024 18:06, Geert Uytterhoeven wrote:

Hi Claudiu,

On Thu, Mar 7, 2024 at 3:08 PM Claudiu [off-list ref] wrote:

quoted

From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

The RZG2L_PD_F_CONSOLE is used by the rzg2l-cpg driver to check if the
SCIF domain need to be powered off in suspend. This is necessary when
no_console_suspend is available in bootargs as we want to still see
output on console, thus scif0 domain should remain powered on.

Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

Thanks for your patch!

quoted

--- a/drivers/clk/renesas/r9a08g045-cpg.c
+++ b/drivers/clk/renesas/r9a08g045-cpg.c

@@ -293,7 +293,7 @@ static const struct rzg2l_cpg_pm_domain_init_data r9a08g045_pm_domains[] = {
        DEF_PD("scif0",         R9A08G045_PD_SCIF0,
                                DEF_REG_CONF(CPG_BUS_MCPU2_MSTOP, BIT(1)),
                                DEF_REG_CONF(0, 0),
-                               RZG2L_PD_F_NONE),
+                               RZG2L_PD_F_CONSOLE),

This is not really correct: if SCIF0 is used as the console depends on the
use case, i.e. on chosen/stdout-path.
So this flag should be set at run-time. You can check the power-domains
property of the node pointed to by of_stdout to find the PM Domain that
holds the console, cfr. drivers/pmdomain/renesas/rmobile-sysc.c.

OK, I'll double check.

Thank you,
Claudiu Beznea

quoted

 };

 const struct rzg2l_cpg_info r9a08g045_cpg_info = {

Gr{oetje,eeting}s,

                        Geert