Re: [PATCH v4 3/8] dt-bindings: phy: Add QMP UFS PHY compatible for SC7180
From: Rob Herring <robh@kernel.org>
Date: 2024-02-12 22:21:11
Also in:
linux-arm-msm, linux-crypto, linux-phy, linux-scsi, lkml
On Sun, Jan 21, 2024 at 05:57:43PM +0100, David Wronek wrote:
quoted hunk ↗ jump to hunk
Document the QMP UFS PHY compatible for SC7180 Acked-by: Rob Herring <robh@kernel.org> Signed-off-by: David Wronek <redacted> --- Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml | 2 ++ 1 file changed, 2 insertions(+)diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml index 8474eef8d0ff..5faa1cb3a12e 100644 --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml@@ -19,6 +19,7 @@ properties: - qcom,msm8996-qmp-ufs-phy - qcom,msm8998-qmp-ufs-phy - qcom,sa8775p-qmp-ufs-phy + - qcom,sc7180-qmp-ufs-phy
This doesn't match what you put in the dts which is adding to the
warnings:
51 phy@1d87000: compatible: ['qcom,sc7180-qmp-ufs-phy', 'qcom,sm7150-qmp-ufs-phy'] is too long
51 phy@1d87000: clock-names: ['ref', 'ref_aux'] is too short
48 phy@1d87000: clocks: [[39, 97], [39, 103]] is too short
30 phy@1d87000: 'power-domains' is a required property
quoted hunk ↗ jump to hunk
- qcom,sc7280-qmp-ufs-phy - qcom,sc8180x-qmp-ufs-phy - qcom,sc8280xp-qmp-ufs-phy@@ -102,6 +103,7 @@ allOf: contains: enum: - qcom,msm8998-qmp-ufs-phy + - qcom,sc7180-qmp-ufs-phy - qcom,sc8180x-qmp-ufs-phy - qcom,sc8280xp-qmp-ufs-phy - qcom,sdm845-qmp-ufs-phy-- 2.43.0