Re: [PATCH v6 2/9] watchdog: rzg2l_wdt: Make the driver depend on PM
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2024-02-08 12:53:52
Also in:
linux-renesas-soc, linux-watchdog, lkml
Hi Claudiu, On Thu, Feb 8, 2024 at 1:26 PM Claudiu [off-list ref] wrote:
From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> The rzg2l_wdt watchdog driver cannot work w/o CONFIG_PM=y (e.g. the clocks are enabled though pm_runtime_* specific APIs). To avoid building a driver that doesn't work make explicit the dependency on CONFIG_PM. Suggested-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> --- Changes in v6: - update patch description - fixed the dependency on COMPILE_TEST previously introduced
Thanks for the update!
quoted hunk ↗ jump to hunk
--- a/drivers/watchdog/Kconfig +++ b/drivers/watchdog/Kconfig@@ -911,6 +911,7 @@ config RENESAS_RZN1WDT config RENESAS_RZG2LWDT tristate "Renesas RZ/G2L WDT Watchdog" depends on ARCH_RZG2L || ARCH_R9A09G011 || COMPILE_TEST + depends on PM
depends on PM || COMPILE_TEST
select WATCHDOG_CORE
help
This driver adds watchdog support for the integrated watchdogs in the
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds