Re: [PATCH] dt-bindings: pinctrl: cy8x95x0: Minor fix & update
From: Conor Dooley <conor@kernel.org>
Date: 2024-01-26 16:48:54
Also in:
linux-gpio, lkml
On Fri, Jan 26, 2024 at 05:27:48PM +0530, Naresh Solanki wrote:
Update maxItems to 60 for gpio-reserved-ranges. Add input-enable property. Rearrange allOf Update example.
Same as elsewhere, please justify the changes rather than list what can be seen in the diff.
TEST=Run below command make sure there is no error. make DT_CHECKER_FLAGS=-m dt_binding_check
Same comment as elsewhere :) Thanks, Conor.
quoted hunk ↗ jump to hunk
Signed-off-by: Naresh Solanki <redacted> --- .../bindings/pinctrl/cypress,cy8c95x0.yaml | 28 +++++++++++++++---- 1 file changed, 23 insertions(+), 5 deletions(-)diff --git a/Documentation/devicetree/bindings/pinctrl/cypress,cy8c95x0.yaml b/Documentation/devicetree/bindings/pinctrl/cypress,cy8c95x0.yaml index 7f30ec2f1e54..89ce0cb68834 100644 --- a/Documentation/devicetree/bindings/pinctrl/cypress,cy8c95x0.yaml +++ b/Documentation/devicetree/bindings/pinctrl/cypress,cy8c95x0.yaml@@ -45,7 +45,8 @@ properties: maxItems: 1 gpio-reserved-ranges: - maxItems: 1 + minItems: 1 + maxItems: 60 vdd-supply: description:@@ -85,6 +86,8 @@ patternProperties: bias-disable: true + input-enable: true + output-high: true output-low: true@@ -101,6 +104,9 @@ patternProperties: additionalProperties: false +allOf: + - $ref: pinctrl.yaml# + required: - compatible - reg@@ -112,9 +118,6 @@ required: additionalProperties: false -allOf: - - $ref: pinctrl.yaml# - examples: - | #include <dt-bindings/interrupt-controller/arm-gic.h>@@ -133,6 +136,21 @@ examples: interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>; interrupt-controller; vdd-supply = <&p3v3>; - gpio-reserved-ranges = <5 1>; + gpio-reserved-ranges = <1 2>, <6 1>, <10 1>, <15 1>; + + pinctrl-0 = <&U62160_pins>, <&U62160_ipins>; + pinctrl-names = "default"; + U62160_pins: cfg-pins { + pins = "gp03", "gp16", "gp20", "gp50", "gp51"; + function = "gpio"; + input-enable; + bias-pull-up; + }; + U62160_ipins: icfg-pins { + pins = "gp04", "gp17", "gp21", "gp52", "gp53"; + function = "gpio"; + input-enable; + bias-pull-up; + }; }; };base-commit: ecb1b8288dc7ccbdcb3b9df005fa1c0e0c0388a7 -- 2.42.0
Attachments
- signature.asc [application/pgp-signature] 228 bytes