Re: [PATCH v3 1/8] dt-bindings: clock: qcom: Allow VDD_GFX supply to GX

On Thu, Jan 25, 2024 at 08:39:15AM +0100, Krzysztof Kozlowski wrote:

On 24/01/2024 22:21, Bjorn Andersson wrote:

quoted

On Wed, Jan 24, 2024 at 07:31:34AM +0100, Krzysztof Kozlowski wrote:

quoted

On 24/01/2024 05:25, Bjorn Andersson wrote:

quoted

+# Allow either power-domains or vdd-gfx-supply, not both
+oneOf:
+  - required:
+      - power-domains
+  - required:
+      - vdd-gfx-supply
+  - not:
+      anyOf:
+        - required:
+            - power-domains
+        - required:
+            - vdd-gfx-supply

I don't fully understand what you want to achieve here. If only "allow
either", so not a "require either", then simpler:

https://lore.kernel.org/all/20230118163208.GA117919-robh@kernel.org/ (local)

As discussed in v2, power-domains is currently an optional property in
this binding and I'm adding vdd-gfx-supply as an alternative to that.

Then go with Rob's syntax - not:required: Much easier code.

I looked at it, but was not able to understand that it expressed my
desired result. Now I do, and I agree with you, so will update it.

Thanks,
Bjorn