Re: [PATCH v2] riscv: dts: sophgo: add watchdog dt node for CV1800

From
Conor Dooley <conor@kernel.org>
Date
2024-01-25 17:10:51
Also in
linux-riscv, lkml
Reply to
Krzysztof Kozlowski, 2024-01-25
On Thu, Jan 25, 2024 at 01:39:51PM +0100, Krzysztof Kozlowski wrote:
On 25/01/2024 10:46, AnnanLiu wrote:
quoted
+
+		pclk: pclk {
+			#clock-cells = <0>;
+			compatible = "fixed-clock";
+			clock-frequency = <25000000>;
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Also, why do you describe internal clock as stub?
Under the --- line it says the patch depends on the clock series, but
as you pointed out the clock is a "fake" stub, so I don't understand
what the dependency would be.

Attachments

Thread (11 messages) 11 messages, 9 authors, last reply 2025-02-14
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help