RE: [PATCH v3.1 3/8] dt-bindings: watchdog: dlg,da9062-watchdog: Document DA9063 watchdog

From
Biju Das <biju.das.jz@bp.renesas.com>
Date
2023-12-05 09:01:13
Also in
linux-renesas-soc, linux-watchdog
Reply to
Geert Uytterhoeven, 2023-12-05
Hi Geert,

Thanks for the feedback.
-----Original Message-----
From: Geert Uytterhoeven <geert@linux-m68k.org>
Sent: Tuesday, December 5, 2023 8:47 AM
Subject: Re: [PATCH v3.1 3/8] dt-bindings: watchdog: dlg,da9062-watchdog:
Document DA9063 watchdog

Hi Biju,

On Mon, Dec 4, 2023 at 6:25 PM Biju Das [off-list ref]
wrote:
quoted
Document DA9063 watchdog device as it is similar to DA9062 watchdog.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
---
v3->v3.1:
 * Added Ack from Conor Dooley.
 * Updated title DA9062/61->DA906{1,2,3} as it supports DA9063.
 * Retained Rb tag since the changes are trivial.
Thanks for the update!
quoted
---
a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
+++ b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.y
+++ aml
quoted
@@ -18,6 +18,7 @@ properties:
       - items:
           - enum:
               - dlg,da9062-watchdog
+              - dlg,da9063-watchdog
       - items:
           - const: dlg,da9061-watchdog
           - const: dlg,da9062-watchdog
This matches the existing usage in DT, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

However, I believe we do have a runtime issue here, as the driver
currently matches against dlg,da9062-watchdog only, so the watchdog must
be non-functional on DA9063?
Of_compatible is defined in [1], but the corresponding driver[2] is missing the compatible
[1]
drivers/mfd/da9063-core.c:		.of_compatible	= "dlg,da9063-watchdog",

[2]
drivers/watchdog/da9063_wdt.c

Not sure of_compaible in MFD will instantiate driver [2] or not?

Cheers,
Biju
Thread (30 messages) 30 messages, 6 authors, last reply 2023-12-12
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help