Thread (1 message) 1 message, 1 author, 2023-10-19

Re: [v4 1/3] drm/panel: ili9882t: Break out as separate driver

From: Doug Anderson <dianders@chromium.org>
Date: 2023-10-19 21:50:03
Also in: dri-devel, lkml

Hi,

On Fri, Oct 13, 2023 at 2:19 AM Cong Yang
[off-list ref] wrote:
The Starry ILI9882t-based panel should never have been part of the boe
tv101wum driver, it is clearly based on the Ilitek ILI9882t display
controller and if you look at the custom command sequences for the
panel these clearly contain the signature Ilitek page switch (0xff)
commands. The hardware has nothing in common with the other panels
supported by this driver.

Break this out into a separate driver and config symbol instead.

If the placement here is out of convenience for using similar code,
we should consider creating a helper library instead.

Co-developed-by: Linus Walleij <redacted>
Signed-off-by: Linus Walleij <redacted>
Reviewed-by: Linus Walleij <redacted>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Cong Yang <redacted>
---
 drivers/gpu/drm/panel/Kconfig                 |   9 +
 drivers/gpu/drm/panel/Makefile                |   1 +
 .../gpu/drm/panel/panel-boe-tv101wum-nl6.c    | 371 ---------
 drivers/gpu/drm/panel/panel-ilitek-ili9882t.c | 759 ++++++++++++++++++
 4 files changed, 769 insertions(+), 371 deletions(-)
 create mode 100644 drivers/gpu/drm/panel/panel-ilitek-ili9882t.c
Pushed to drm-misc-next:

e2450d32e5fb drm/panel: ili9882t: Break out as separate driver
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help