RE: [PATCH v8 20/26] dt-bindings: devfreq: event: convert Rockchip DFI binding to yaml
From: "Chanwoo Choi" <cw00.choi@samsung.com>
Date: 2023-10-19 12:25:05
Also in:
linux-arm-kernel, linux-pm, linux-rockchip, lkml
quoted hunk ↗ jump to hunk
-----Original Message----- From: Sascha Hauer <s.hauer@pengutronix.de> Sent: Wednesday, October 18, 2023 3:17 PM To: linux-rockchip@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; linux-pm@vger.kernel.org; Heiko Stuebner [off-list ref]; Chanwoo Choi [off-list ref]; Kyungmin Park [off-list ref]; MyungJoo Ham [off-list ref]; Will Deacon [off-list ref]; Mark Rutland [off-list ref]; kernel@pengutronix.de; Michael Riesch [off-list ref]; Robin Murphy [off-list ref]; Vincent Legoll [off-list ref]; Rob Herring [off-list ref]; Krzysztof Kozlowski [off-list ref]; Conor Dooley [off-list ref]; devicetree@vger.kernel.org; Sebastian Reichel [off-list ref]; Sascha Hauer [off-list ref]; Rob Herring [off-list ref]; Chanwoo Choi [off-list ref] Subject: [PATCH v8 20/26] dt-bindings: devfreq: event: convert Rockchip DFI binding to yaml Convert the Rockchip DFI binding to yaml. Reviewed-by: Rob Herring <robh@kernel.org> Reviewed-by: Sebastian Reichel <redacted> Acked-by: Chanwoo Choi <cw00.choi@samsung.com> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> --- Notes: Changes since v4: - Revert to state of v3 (changes were lost in v4) .../bindings/devfreq/event/rockchip,dfi.yaml | 61 +++++++++++++++++++ .../bindings/devfreq/event/rockchip-dfi.txt | 18 ------ .../rockchip,rk3399-dmc.yaml | 2 +- 3 files changed, 62 insertions(+), 19 deletions(-) create mode 100644 Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml delete mode 100644 Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml b/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml new file mode 100644 index 0000000000000..7a82f6ae0701e--- /dev/null +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml@@ -0,0 +1,61 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 +--- +$id: +https://protect2.fireeye.com/v1/url?k=33df13d2-525406e4-33de989d-000bab +ff9b5d-4b7a223f95f3c587&q=1&e=ef8cc89e-5dd5-4fbc-9f53-24c072471908&u=ht +tp%3A%2F%2Fdevicetree.org%2Fschemas%2Fdevfreq%2Fevent%2Frockchip%2Cdfi. +yaml%23 +$schema: +https://protect2.fireeye.com/v1/url?k=01ded479-6055c14f-01df5f36-000bab +ff9b5d-e828a5719f87a6ff&q=1&e=ef8cc89e-5dd5-4fbc-9f53-24c072471908&u=ht +tp%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 + +title: Rockchip DFI + +maintainers: + - Sascha Hauer <s.hauer@pengutronix.de> + +properties: + compatible: + enum: + - rockchip,rk3399-dfi + + clocks: + maxItems: 1 + + clock-names: + items: + - const: pclk_ddr_mon + + interrupts: + maxItems: 1 + + reg: + maxItems: 1 + + rockchip,pmu: + $ref: /schemas/types.yaml#/definitions/phandle + description: + Phandle to the syscon managing the "PMU general register files". + +required: + - compatible + - clocks + - clock-names + - interrupts + - reg + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/clock/rk3308-cru.h> + + bus { + #address-cells = <2>; + #size-cells = <2>; + + dfi: dfi@ff630000 { + compatible = "rockchip,rk3399-dfi"; + reg = <0x00 0xff630000 0x00 0x4000>; + interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH 0>; + rockchip,pmu = <&pmugrf>; + clocks = <&cru PCLK_DDR_MON>; + clock-names = "pclk_ddr_mon"; + }; + };diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt deleted file mode 100644 index 148191b0fc158..0000000000000--- a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt +++ /dev/null@@ -1,18 +0,0 @@ - -* Rockchip rk3399 DFI device - -Required properties: -- compatible: Must be "rockchip,rk3399-dfi". -- reg: physical base address of each DFI and length of memory mappedregion -- rockchip,pmu: phandle to the syscon managing the "pmu general register files" -- clocks: phandles for clock specified in "clock-names" property -- clock-names : the name of clock used by the DFI, must be
"pclk_ddr_mon";
quoted hunk ↗ jump to hunk
- -Example: - dfi: dfi@ff630000 { - compatible = "rockchip,rk3399-dfi"; - reg = <0x00 0xff630000 0x00 0x4000>; - rockchip,pmu = <&pmugrf>; - clocks = <&cru PCLK_DDR_MON>; - clock-names = "pclk_ddr_mon"; - };diff --git a/Documentation/devicetree/bindings/memory-controllers/rockchip,rk3399-dmc.yaml b/Documentation/devicetree/bindings/memory-controllers/rockchip,rk3399- dmc.yaml index 4e4af3cfc0fe4..1f58ee99be280 100644--- a/Documentation/devicetree/bindings/memory-controllers/rockchip,rk3399-dmc.yaml+++ b/Documentation/devicetree/bindings/memory-controllers/rockchip,rk33 +++ 99-dmc.yaml@@ -18,7 +18,7 @@ properties: $ref: /schemas/types.yaml#/definitions/phandle description: Node to get DDR loading. Refer to - Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt. + Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml. clocks: maxItems: 1 --2.39.2
Applied it. Thanks Best Regards, Chanwoo Choi