Re: [PATCH v3 1/3] dt-bindings: imx8-jpeg: Add clocks entries

On 13/09/2023 09:04, Krzysztof Kozlowski wrote:

On 12/09/2023 18:38, Fabio Estevam wrote:

quoted

From: Fabio Estevam <redacted>

The JPEG decoder/encoder present in iMX8QXP and iMX8QM SoCs need
the PER and IPG clocks to be functional, so add the clock entries.

This also fixes the following schema warning: 

imx8qm-apalis-eval.dtb: jpegdec@58400000: 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/media/nxp,imx8-jpeg.yaml#

Signed-off-by: Fabio Estevam <redacted>
---
Changes since v2:
- Remove clock-names. (Mirela)

 .../devicetree/bindings/media/nxp,imx8-jpeg.yaml         | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
index 3d9d1db37040..3383a275c94a 100644
--- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
+++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml

@@ -31,6 +31,9 @@ properties:
   reg:
     maxItems: 1
 
+  clocks:
+    maxItems: 2

You need to describe the clocks, so "items" with descriptions instead of
maxItems.

And to be clear: such description was in your previous version, so it's
the problem introduced now in v3...

Best regards,
Krzysztof