Re: [PATCH v2 8/8] arm64: defconfig: enable interconnect and pinctrl for SM4450

Hi Trilok,

On 16.09.23 5:25, Trilok Soni wrote:

On 9/15/2023 7:21 PM, Trilok Soni wrote:

quoted

On 9/15/2023 4:29 AM, Krzysztof Kozlowski wrote:

quoted

On 15/09/2023 13:18, Tengfei Fan wrote:

quoted

在 9/15/2023 5:16 PM, Krzysztof Kozlowski 写道:

quoted

On 15/09/2023 11:12, Tengfei Fan wrote:

quoted

在 9/15/2023 3:21 PM, Krzysztof Kozlowski 写道:

quoted

On 15/09/2023 04:15, Tengfei Fan wrote:

quoted

Add the SM4450 interconnect and pinctrl drivers as built-in for
support the Qualcomm SM4450 platform to boot to uart shell.

Signed-off-by: Tengfei Fan <redacted>
---
    arch/arm64/configs/defconfig | 2 ++
    1 file changed, 2 insertions(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index ec59174b14db..e91993de865e 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig

@@ -598,6 +598,7 @@ CONFIG_PINCTRL_SC8280XP=y
    CONFIG_PINCTRL_SDM660=y
    CONFIG_PINCTRL_SDM670=y
    CONFIG_PINCTRL_SDM845=y
+CONFIG_PINCTRL_SM4450=y
    CONFIG_PINCTRL_SM6115=y
    CONFIG_PINCTRL_SM6125=y
    CONFIG_PINCTRL_SM6350=y

@@ -1500,6 +1501,7 @@ CONFIG_INTERCONNECT_QCOM_SC7280=y
    CONFIG_INTERCONNECT_QCOM_SC8180X=y
    CONFIG_INTERCONNECT_QCOM_SC8280XP=y
    CONFIG_INTERCONNECT_QCOM_SDM845=y
+CONFIG_INTERCONNECT_QCOM_SM4450=y

Why it cannot be =m?

Best regards,
Krzysztof

Hi Krzysztof,
Because system haven't capacity of loading ko files at this time on
SM4450 platform, so setting to "Y".

Hm? System has this capability. All systems have. What is so different
on SM4450 comparing to everything else we have here?

No, this should be =m and you need to fix your system.

Best regards,
Krzysztof

Hi Krzysztof,
Find new way which can load ko files on SM4450 platform, still need use
"Y", because of some other modules have dependence to these two config,
like scm, smmu module drivers, uart shell console cannot be got if set
to "m".

That's what I am asking, which device exactly needs it.

quoted

Also do test for setting these two config to "m" on SM8450 platform, get
uart shell consle failed if so setting.

Yeah, this we know, I did this. I am asking about SM4450.

Why we have =m requirement when other drivers above are =Y?. Can we confirm
w/ Georgi? I am not aware that Interconnect drivers needs to be =m only.

CONFIG_INTERCONNECT_QCOM_SC8180X=y
CONFIG_INTERCONNECT_QCOM_SC8280XP=y
CONFIG_INTERCONNECT_QCOM_SDM845=y

Complete list here, and it is inconsistent. Latest 8550 is also =y. Do we document
the reasons somewhere on why they are added as =y?

CONFIG_INTERCONNECT_QCOM=y
CONFIG_INTERCONNECT_QCOM_MSM8916=m
CONFIG_INTERCONNECT_QCOM_MSM8996=m
CONFIG_INTERCONNECT_QCOM_OSM_L3=m
CONFIG_INTERCONNECT_QCOM_QCM2290=m
CONFIG_INTERCONNECT_QCOM_QCS404=m
CONFIG_INTERCONNECT_QCOM_SA8775P=y
CONFIG_INTERCONNECT_QCOM_SC7180=y
CONFIG_INTERCONNECT_QCOM_SC7280=y
CONFIG_INTERCONNECT_QCOM_SC8180X=y
CONFIG_INTERCONNECT_QCOM_SC8280XP=y
CONFIG_INTERCONNECT_QCOM_SDM845=y
CONFIG_INTERCONNECT_QCOM_SM8150=m
CONFIG_INTERCONNECT_QCOM_SM8250=m
CONFIG_INTERCONNECT_QCOM_SM8350=m
CONFIG_INTERCONNECT_QCOM_SM8450=y
CONFIG_INTERCONNECT_QCOM_SM8550=y

If the device can boot (to console/initramfs) with =m, we go with that.
But if something critical like the UART depends on the interconnect
provider, then we make it built-in.

On SM8550 for example, we have enabled bandwidth scaling support for QUP
and that's why it needs to be =y.

It looks like on SM4450 this should be =y too.

Thanks,
Georgi