Re: [PATCH v2 06/14] arm64: dts: qcom: sdm630: Drop RPM bus clocks
From: Krzysztof Kozlowski <hidden>
Date: 2023-09-13 07:13:47
Also in:
linux-arm-kernel, linux-arm-msm, linux-iommu, linux-remoteproc, linux-usb, lkml
On 12/09/2023 15:31, Konrad Dybcio wrote:
quoted hunk ↗ jump to hunk
These clocks are now handled from within the icc framework and are no longer registered from within the CCF. Remove them. Signed-off-by: Konrad Dybcio <redacted> --- arch/arm64/boot/dts/qcom/sdm630.dtsi | 49 +++++++----------------------------- 1 file changed, 9 insertions(+), 40 deletions(-)diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi index ec6003212c4d..f11d2a07508c 100644 --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi@@ -605,9 +605,6 @@ bimc: interconnect@1008000 { compatible = "qcom,sdm660-bimc"; reg = <0x01008000 0x78000>; #interconnect-cells = <1>; - clock-names = "bus", "bus_a"; - clocks = <&rpmcc RPM_SMD_BIMC_CLK>, - <&rpmcc RPM_SMD_BIMC_A_CLK>;
Bindings expect here two clocks, so you miss some bindings patches.
quoted hunk ↗ jump to hunk
}; restart@10ac000 {@@ -619,28 +616,17 @@ cnoc: interconnect@1500000 { compatible = "qcom,sdm660-cnoc"; reg = <0x01500000 0x10000>; #interconnect-cells = <1>; - clock-names = "bus", "bus_a"; - clocks = <&rpmcc RPM_SMD_CNOC_CLK>, - <&rpmcc RPM_SMD_CNOC_A_CLK>; }; snoc: interconnect@1626000 { compatible = "qcom,sdm660-snoc"; reg = <0x01626000 0x7090>; #interconnect-cells = <1>; - clock-names = "bus", "bus_a"; - clocks = <&rpmcc RPM_SMD_SNOC_CLK>, - <&rpmcc RPM_SMD_SNOC_A_CLK>; }; anoc2_smmu: iommu@16c0000 { compatible = "qcom,sdm630-smmu-v2", "qcom,smmu-v2"; reg = <0x016c0000 0x40000>; - - assigned-clocks = <&rpmcc RPM_SMD_AGGR2_NOC_CLK>; - assigned-clock-rates = <1000>; - clocks = <&rpmcc RPM_SMD_AGGR2_NOC_CLK>; - clock-names = "bus";
This is also against bindings. After your patch #4, such bus clock (or other combinations) is still required.
quoted hunk ↗ jump to hunk
#global-interrupts = <2>; #iommu-cells = <1>;@@ -685,16 +671,12 @@ a2noc: interconnect@1704000 { compatible = "qcom,sdm660-a2noc"; reg = <0x01704000 0xc100>; #interconnect-cells = <1>; - clock-names = "bus", - "bus_a", - "ipa", + clock-names = "ipa",
And which bindings does this match? Best regards, Krzysztof