Re: [PATCH v3 4/5] clk: twl: add clock driver for TWL6032

From
Stephen Boyd <sboyd@kernel.org>
Date
2023-09-12 18:04:08
Also in
linux-clk, linux-input, linux-omap, lkml
Reply to
Andreas Kemnade, 2023-09-12
Quoting Andreas Kemnade (2023-09-11 15:13:45)
quoted hunk ↗ jump to hunk
diff --git a/drivers/clk/clk-twl.c b/drivers/clk/clk-twl.c
new file mode 100644
index 0000000000000..09006e53a32ec
--- /dev/null
+++ b/drivers/clk/clk-twl.c
@@ -0,0 +1,197 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Clock driver for twl device.
+ *
+ * inspired by the driver for the Palmas device
+ */
+
+#include <linux/clk.h>
Please drop this include unless it is used.
quoted hunk ↗ jump to hunk
+#include <linux/clk-provider.h>
+#include <linux/mfd/twl.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <linux/slab.h>
+
+#define VREG_STATE              2
+#define TWL6030_CFG_STATE_OFF   0x00
+#define TWL6030_CFG_STATE_ON    0x01
+#define TWL6030_CFG_STATE_MASK  0x03
+
+struct twl_clock_info {
+       struct device *dev;
+       u8 base;
+       struct clk_hw hw;
+};
[...]
quoted hunk ↗ jump to hunk
+
+static int twl_clks_probe(struct platform_device *pdev)
+{
+       struct clk_hw_onecell_data *clk_data;
+       const struct twl_clks_data *hw_data;
+
+       struct twl_clock_info *cinfo;
+       int ret;
+       int i;
+       int count;
+
+       hw_data = twl6032_clks;
+       for (count = 0; hw_data[count].init.name; count++)
+               ;
+
+       clk_data = devm_kzalloc(&pdev->dev,
+                               struct_size(clk_data, hws, count),
+                               GFP_KERNEL);
+       if (!clk_data)
+               return -ENOMEM;
+
+       clk_data->num = count;
+       cinfo = devm_kcalloc(&pdev->dev, count, sizeof(*cinfo), GFP_KERNEL);
+       if (!cinfo)
+               return -ENOMEM;
+
+       for (i = 0; i < count; i++) {
+               cinfo[i].base = hw_data[i].base;
+               cinfo[i].dev = &pdev->dev;
+               cinfo[i].hw.init = &hw_data[i].init;
+               ret = devm_clk_hw_register(&pdev->dev, &cinfo[i].hw);
+               if (ret) {
+                       dev_err(&pdev->dev, "Fail to register clock %s, %d\n",
Use dev_err_probe()
quoted hunk ↗ jump to hunk
+                               hw_data[i].init.name, ret);
+                       return ret;
+               }
+               clk_data->hws[i] = &cinfo[i].hw;
+       }
+
+       ret = devm_of_clk_add_hw_provider(&pdev->dev,
+                                         of_clk_hw_onecell_get, clk_data);
+       if (ret < 0)
+               dev_err(&pdev->dev, "Fail to add clock driver, %d\n", ret);
Use dev_err_probe()
+
+       return ret;
Thread (11 messages) 11 messages, 4 authors, last reply 2023-10-07
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help