Thread (1 message) 1 message, 1 author, 2023-08-18

RE: [PATCH v2 5/5] iio: magnetometer: ak8975: Sort OF table

flat view

From: Biju Das <biju.das.jz@bp.renesas.com>
Date: 2023-08-18 15:07:43
Also in: linux-iio, linux-renesas-soc

Hi Andy Shevchenko,
Subject: Re: [PATCH v2 5/5] iio: magnetometer: ak8975: Sort OF table

On Fri, Aug 18, 2023 at 11:39:03AM +0000, Biju Das wrote:
quoted
quoted
On Fri, Aug 18, 2023 at 08:56:00AM +0100, Biju Das wrote:
quoted
Sort OF table alphabetically by compatibles.
quoted
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Wrong, I haven't suggested that. See comment to the previous patch.

And this is definitely wrong as Geert explained already why.
You need to fix the code that handles the ID table first.
That rule applicable only for fallback. I checked bindings and there are
no fallbacks.

You can't check the _whole_ world, so you checked only bindings that are in
tree.
But it doesn't matter as a user somewhere may use something you have no
access to.
Yes true, for those not using tree can patch bindings and modify the
driver and dts accordingly.

If they are using tree, they must go with binding docs and update driver/bindings accordingly.

+ device_tree.

Cheers,
Biju
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help