On Tue, Aug 29, 2023 at 01:01:44PM +0200, Ulf Hansson wrote:

On Mon, 28 Aug 2023 at 13:42, Konrad Dybcio [off-list ref] wrote:

quoted

From: AngeloGioacchino Del Regno <redacted>

Add the bindings for the CPR3 driver to the documentation.

Signed-off-by: AngeloGioacchino Del Regno <redacted>
[Konrad: Make binding check pass; update AGdR's email]
Tested-by: Jeffrey Hugo <redacted>
Signed-off-by: Konrad Dybcio <redacted>
---
 .../devicetree/bindings/soc/qcom/qcom,cpr3.yaml    | 286 +++++++++++++++++++++
 1 file changed, 286 insertions(+)

diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml
new file mode 100644
index 000000000000..acf2e294866b

[...]

quoted

+
+examples:
+  - |
+    #include <dt-bindings/clock/qcom,gcc-msm8998.h>
+    #include <dt-bindings/interrupt-controller/irq.h>
+
+    cpus {
+        #address-cells = <2>;
+        #size-cells = <0>;
+
+        cpu@0 {
+            compatible = "qcom,kryo280";
+            device_type = "cpu";
+            reg = <0x0 0x0>;
+            operating-points-v2 = <&cpu0_opp_table>;
+            power-domains = <&apc_cprh 0>;
+            power-domain-names = "cprh";

Rather than using a Qcom specific power-domain-name, perhaps a common
power-domain-name for cpus, that can be used for "the performance
domain" would be a good idea here?

I have suggested using "perf" for the SCMI performance domain [1],
perhaps that description should be extended to cover this and other
performance domains too?

Better yet, nothing. There's no value to -names when there is only 1 
entry.

Rob