Thread (19 messages) 19 messages, 3 authors, 2023-08-31

Re: [PATCH 4/5] arm64: dts: qcom: ipq5018: Add USB related nodes

From: Nitheesh Sekar <hidden>
Date: 2023-08-30 19:14:47
Also in: linux-arm-msm, linux-phy, linux-usb, lkml

On 8/25/2023 4:09 PM, Krzysztof Kozlowski wrote:
On 25/08/2023 11:35, Nitheesh Sekar wrote:
quoted
Add USB phy and controller nodes.

Co-developed-by: Amandeep Singh <redacted>
Signed-off-by: Amandeep Singh <redacted>
Signed-off-by: Nitheesh Sekar <redacted>
---
  arch/arm64/boot/dts/qcom/ipq5018.dtsi | 54 +++++++++++++++++++++++++++
  1 file changed, 54 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
index 9f13d2dcdfd5..ff477923a823 100644
--- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
@@ -238,6 +238,60 @@
  				status = "disabled";
  			};
  		};
+
+		usbphy0: phy@5b000 {
+			compatible = "qcom,ipq5018-usb-hsphy";
+			reg = <0x0005b000 0x120>;
+
+			clocks = <&gcc GCC_USB0_PHY_CFG_AHB_CLK>;
+
+			resets = <&gcc GCC_QUSB2_0_PHY_BCR>;
+
+			#phy-cells = <0>;
+
+			status = "disabled";
+		};
+
+		usb: usb2@8a00000 {
Eee, where did you put these? Don't stuff things to the end of any list.
This applies to your entire code: Makefile, Kconfig, .c, .h, .dts, .dtsi
and other languages and projects as well.
Will reorder accordingly and post an update.

Regards,
Nitheesh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help