Re: [PATCH 1/4] dt-bindings: net: dsa: microchip,lan937x: add missing ethernet on example
From: Vladimir Oltean <olteanv@gmail.com>
Date: 2023-08-14 14:56:00
Also in:
linux-arm-kernel, linux-mediatek, lkml, netdev
On Sat, Aug 12, 2023 at 12:17:05PM +0300, Arınç ÜNAL wrote:
The port@5 node on the example is missing the ethernet property. Add it. Remove the MAC bindings on the example as they cannot be validated. Signed-off-by: Arınç ÜNAL <redacted> ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
quoted hunk ↗ jump to hunk
.../bindings/net/dsa/microchip,lan937x.yaml | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-)diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,lan937x.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,lan937x.yaml index 8d7e878b84dc..49af4b0d5916 100644 --- a/Documentation/devicetree/bindings/net/dsa/microchip,lan937x.yaml +++ b/Documentation/devicetree/bindings/net/dsa/microchip,lan937x.yaml@@ -68,16 +68,6 @@ examples: - | #include <dt-bindings/gpio/gpio.h> - macb0 { - #address-cells = <1>; - #size-cells = <0>; - - fixed-link { - speed = <1000>; - full-duplex; - }; - }; - spi { #address-cells = <1>; #size-cells = <0>;@@ -138,6 +128,7 @@ examples: phy-mode = "rgmii"; tx-internal-delay-ps = <2000>; rx-internal-delay-ps = <2000>; + ethernet = <&macb1>; fixed-link { speed = <1000>;-- 2.39.2