Thread (9 messages) 9 messages, 2 authors, 2023-08-04

Re: [PATCH v4 1/1] riscv: dts: sifive: unleashed/unmatched: Remove PWM controlled LED's active-low properties

From: Nylon Chen <hidden>
Date: 2023-08-03 09:28:58
Also in: linux-riscv, lkml

Hi Conor,

I apologize for forgetting about this update earlier. Just now,
I tried to pull rebase master and noticed that other developers seem
to have made some fixes to the algorithm. Upon closer inspection, I
found that they addressed the part we previously discussed with Emil
and Uwe, such as "first pwm_apply_state."

Therefore, my instinct tells me that they have already taken care of
the issues we discussed before.

I will review the conflicting parts in the pwm-sifive.c code in my v4
version once again to ensure there are no omissions. If I find any, I
will submit v5 accordingly.

Conor Dooley [off-list ref] 於 2023年8月3日 週四 下午5:19寫道:
On Thu, Aug 03, 2023 at 04:57:34PM +0800, Nylon Chen wrote:
quoted
This removes the active-low properties of the PWM-controlled LEDs in
the HiFive Unmatched device tree.

The reference is hifive-unleashed-a00.pdf[0] and hifive-unmatched-schematics-v3.pdf[1].

Link: https://sifive.cdn.prismic.io/sifive/c52a8e32-05ce-4aaf-95c8-7bf8453f8698_hifive-unleashed-a00-schematics-1.pdf [0]
Link: https://sifive.cdn.prismic.io/sifive/6a06d6c0-6e66-49b5-8e9e-e68ce76f4192_hifive-unmatched-schematics-v3.pdf [1]
quoted
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Since there is no PWM driver patch for this to go along with, this ack
doesn't mean anything anymore. Please drop it if you resubmit.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help