Re: [PATCH v1 2/2] misc: adps990x: convert to OF

31 липня 2023 р. 16:18:16 GMT+03:00, Arnd Bergmann [off-list ref] написав(-ла):

On Mon, Jul 31, 2023, at 13:02, Svyatoslav Ryhel wrote:

quoted

Add ability to use device tree bindings keeping existing setup.

I see that there are no more in-tree users of the old
apds990x_platform_data, so I think it would be best to completely
remove that codepath and merge that structure into struct
apds990x_chip, to simplify the probing and avoid the extra
allocation.

Thank you very much for your review, but is it mandatory to drop pdata in this particular patch set? To be honest this driver needs serious upgrades and refactoring, and I have no dedication to invest my time into refactoring it, moreover, I am not a maintainer of this driver, nor a full time kernel maintainer of any kind. I am doing what I am doing only because one of my devices uses this als but it is not something crucial.

Best regards,
Svyatoslav R.

  Arnd