Thread (8 messages) 8 messages, 2 authors, 2023-07-27

Re: [PATCH v6 1/5] dt-bindings: phy: qcom,m31: Document qcom,m31 USB phy

From: Krzysztof Kozlowski <hidden>
Date: 2023-07-27 06:47:21
Also in: linux-arm-kernel, linux-arm-msm, linux-phy, lkml

On 27/07/2023 08:33, Varadarajan Narayanan wrote:
Document the M31 USB2 phy present in IPQ5332.

Co-developed-by: Sricharan Ramabadhran <redacted>
Signed-off-by: Sricharan Ramabadhran <redacted>
Signed-off-by: Varadarajan Narayanan <redacted>
---
+properties:
+  "#phy-cells":
+    const: 0
+
+  compatible:
+    items:
+      - const: qcom,ipq5332-usb-hsphy
Please keep compatible as first property.
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    items:
+      - const: cfg_ahb
+
+  resets:
+    maxItems: 1
+
+  vdd-supply:
+    description:
+      Phandle to 5V regulator supply to PHY digital circuit.
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/qcom,ipq5332-gcc.h>
+    usb2-phy@7b000 {
This was actually better before as usb-phy, I don't know why did you
changed. Especially that you already changed once to usb-phy and this
got review tag. It's fine. If there is going to be resubmit then fix
these two issues.

Reviewed-by: Krzysztof Kozlowski <redacted>

Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help