Thread (23 messages) 23 messages, 3 authors, 2023-08-07

Re: [RESEND PATCH v8 06/10] serial: sc16is7xx: fix regression with GPIO configuration

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2023-07-22 15:15:39
Also in: linux-gpio, linux-serial, lkml, stable

On Sat, Jul 22, 2023 at 10:47:24AM -0400, Hugo Villeneuve wrote:
On Fri, 21 Jul 2023 13:24:19 -0600
Rob Herring [off-list ref] wrote:
quoted
On Fri, Jul 21, 2023 at 10:19 AM Hugo Villeneuve [off-list ref] wrote:
quoted
From: Hugo Villeneuve <hvilleneuve@dimonoff.com>

Commit 679875d1d880 ("sc16is7xx: Separate GPIOs from modem control lines")
and commit 21144bab4f11 ("sc16is7xx: Handle modem status lines")
changed the function of the GPIOs pins to act as modem control
lines without any possibility of selecting GPIO function.
Requiring a new DT property is not fixing a kernel regression. You
should be returning the kernel to original behavior and then have a
new DT property for new behavior.
Hi Rob,
please read the entire patch history starting from V1
 and you will understand why this course of action was
 not selected.
That's not going to happen, sorry, you need to explain it here, in this
patch series, why a specific action is being taken over another one, as
no one has time to go dig through past history, sorry.

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help