Re: [PATCH] dmaengine: Explicitly include correct DT includes

From
Rob Herring <robh@kernel.org>
Date
2023-07-17 16:03:19
Also in
asahi, dmaengine, linux-arm-msm, linux-mips, linux-sunxi, linux-tegra, linuxppc-dev, lkml
Reply to
Rob Herring, 2023-07-14
On Fri, Jul 14, 2023 at 11:44 AM Rob Herring [off-list ref] wrote:
The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 drivers/dma/apple-admac.c                      | 3 ++-
 drivers/dma/at_hdmac.c                         | 2 +-
 drivers/dma/bcm-sba-raid.c                     | 4 +++-
 drivers/dma/bestcomm/bestcomm.c                | 4 +---
v2 coming for this:
quoted
drivers/dma/bestcomm/bestcomm.
c:80:13: error: call to undeclared function 'irq_of_parse_and_map';
ISO C99 and later do not support implicit function declarations
[-Wimplicit-function-declaration]
      80 |         tsk->irq = irq_of_parse_and_map(bcom_eng->ofnode,
tsk->tasknum);
         |                    ^
quoted
drivers/dma/bestcomm/bestcomm.c:105:4: error: call to undeclared function 'irq_dispose_mapping'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     105 |                         irq_dispose_mapping(tsk->irq);
         |                         ^
   drivers/dma/bestcomm/bestcomm.c:128:2: error: call to undeclared
function 'irq_dispose_mapping'; ISO C99 and later do not support
implicit function declarations [-Wimplicit-function-declaration]
     128 |         irq_dispose_mapping(tsk->irq);
         |         ^
   3 errors generated.
Thread (2 messages) 2 messages, 1 author, last reply 2023-07-17
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help