-----Original Message-----
From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
Sent: Wednesday, June 21, 2023 6:11 PM
To: Dylan Hung <redacted>; mturquette@baylibre.com;
sboyd@kernel.org; robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
conor+dt@kernel.org; linux-clk@vger.kernel.org; devicetree@vger.kernel.org;
linux-kernel@vger.kernel.org
Cc: BMC-SW <redacted>
Subject: Re: [PATCH] dt-bindings: clock: ast2600: Add I3C and MAC reset
definitions

On 21/06/2023 11:45, Dylan Hung wrote:

quoted

Add reset definitions of AST2600 I3C and MAC controllers.

Signed-off-by: Dylan Hung <redacted>
---
 include/dt-bindings/clock/ast2600-clock.h | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/include/dt-bindings/clock/ast2600-clock.h

b/include/dt-bindings/clock/ast2600-clock.h

quoted

index e149eee61588..07377589f8f4 100644

--- a/include/dt-bindings/clock/ast2600-clock.h
+++ b/include/dt-bindings/clock/ast2600-clock.h

@@ -90,7 +90,18 @@
 /* Only list resets here that are not part of a clock gate + reset pair */
 #define ASPEED_RESET_ADC		55
 #define ASPEED_RESET_JTAG_MASTER2	54
-#define ASPEED_RESET_I3C_DMA		39

This will break all the users.

This define was created but never used. However, if you have concerns about it, I
can include it back in V2.

Best regards,
Krzysztof