Thread (12 messages) 12 messages, 4 authors, 2023-07-13

Re: [PATCH v2 3/5] ASoC: rt5640: Fix sleep in atomic context

From: Mark Brown <broonie@kernel.org>
Date: 2023-06-29 10:15:21
Also in: alsa-devel, linux-tegra, lkml, stable

On Thu, Jun 29, 2023 at 08:38:09AM +0000, David Laight wrote:
From: Sameer Pujar
quoted
Following prints are observed while testing audio on Jetson AGX Orin which
has onboard RT5640 audio codec:

  BUG: sleeping function called from invalid context at kernel/workqueue.c:3027
  in_atomic(): 1, irqs_disabled(): 128, non_block: 0, pid: 0, name: swapper/0
My 'gut feel' is that this will just move the problem elsewhere.
If the ISR is responsible for adding audio buffers (etc) then it is
also not unlikely that the scheduling delays in running a threaded ISR
will cause audio glitches if the system is busy.
What makes you think this is anything to do with audio glitches?  The
bug is literally what is described, it is not valid to sleep in atomic
contexts and if we ever actually try things are likely to go badly.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help