Thread (19 messages) 19 messages, 6 authors, 2023-06-30

Re: [PATCH 2/2] arm64: dts: add support for T7 based Amlogic AN400

From: Conor Dooley <conor.dooley@microchip.com>
Date: 2023-06-27 07:27:29
Also in: linux-amlogic, linux-arm-kernel, lkml

On Mon, Jun 26, 2023 at 05:41:05PM +0200, Krzysztof Kozlowski wrote:
On 26/06/2023 11:52, Xianwei Zhao wrote:
quoted
+
+		apb4: bus@fe000000 {
+			compatible = "simple-bus";
+			reg = <0x0 0xfe000000 0x0 0x480000>;
+			#address-cells = <2>;
+			#size-cells = <2>;
+			ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>;
+
+			uart_a: serial@78000 {
+				compatible = "amlogic,meson-s4-uart",
+					     "amlogic,meson-ao-uart";
+				reg = <0x0 0x78000 0x0 0x18>;
+				interrupts = <GIC_SPI 168 IRQ_TYPE_EDGE_RISING>;
+				status = "disabled";
Please, don't put status in the middle of properties...
The serial entry is also missing the soc specific compatible (and
removal of the always-on uart) that was discussed in Lucas Tanure's
series.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help