Re: [PATCH v7 5/9] serial: sc16is7xx: fix regression with GPIO configuration

On Sun, 4 Jun 2023 22:31:04 +0300
Andy Shevchenko [off-list ref] wrote:

On Sun, Jun 4, 2023 at 8:45 PM Hugo Villeneuve [off-list ref] wrote:

quoted

On Sun, 4 Jun 2023 14:57:31 +0300
Andy Shevchenko [off-list ref] wrote:

quoted

On Sun, Jun 4, 2023 at 10:47 AM Greg KH [off-list ref] wrote:

quoted

On Fri, Jun 02, 2023 at 11:26:21AM -0400, Hugo Villeneuve wrote:

...

quoted

quoted

+static u8 sc16is7xx_setup_mctrl_ports(struct device *dev)

This returns what, mctrl?  If so, please document that, it doesn't look
obvious.

Good suggestion. Because I also stumbled over the returned type.

quoted

 And as the kernel test robot reported, you do nothing with the
return value so why compute it?

It seems that the entire function and respective call has to be moved
under #ifdef CONFIG_GPIOLIB.

Hi,
it cannot. See my explanations in response to Greg's comments.

Then as Greg suggested, store in the structure and make this function
to return an error code (with int), with this amendment you don't need
to add a comment about the returned variable anymore.

Hi Andy,
did you have a chance to look at V8 (sent two weks ago) which fixed all
of what we discussed?

Thank you,
Hugo.