Re: [PATCH 2/2] NFC: nxp-nci: Add pad supply voltage pvdd-supply

From
Jakub Kicinski <kuba@kernel.org>
Date
2023-06-08 04:36:30
Also in
lkml, netdev
Reply to
Raymond Hackley, 2023-06-06
On Tue, 06 Jun 2023 07:25:55 +0000 Raymond Hackley wrote:
quoted hunk ↗ jump to hunk
+			if (r != -EPROBE_DEFER)
+				dev_err(dev,
+					"Failed to get regulator pvdd: %d\n",
+					r);
+			return r;
dev_err_probe() ?
quoted hunk ↗ jump to hunk
+	r = devm_add_action_or_reset(dev, nxp_nci_i2c_poweroff, phy);
+	if (r < 0) {
+		nfc_err(dev, "Failed to install poweroff handler: %d\n",
+			r);
+		nxp_nci_i2c_poweroff(phy);
The _or_reset() stands for "we'll call the action for you if we can't
add it". Don't call poweroff again.
-- 
pw-bot: cr
Thread (5 messages) 5 messages, 3 authors, last reply 2023-06-08
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help