Thread (17 messages) 17 messages, 5 authors, 2023-05-25

Re: [PATCH 3/4] clk: qcom: camcc-sm8550: Add camera clock controller driver for SM8550

From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Date: 2023-05-19 20:26:59
Also in: linux-arm-msm, linux-clk, lkml

On 19/05/2023 16:56, Jagadeesh Kona wrote:
+MODULE_DESCRIPTION("QTI CAM_CC SM8550 Driver");
This pattern looks odd and inconsistent in our clock drivers. We mostly 
have CAMCC or VIDEOCC but occasionally have CAM_CC and VIDEO_CC.

I'd drop that underscore to, in addition to Konrad's comment on Ucase hex.

Other than that, LGTM.

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help