Re: [PATCH v5 2/5] dt-bindings: clocks: atmel,at91rm9200-pmc: convert to yaml

On 18/05/2023 08:03, Claudiu.Beznea@microchip.com wrote:

On 17.05.2023 17:21, Krzysztof Kozlowski wrote:

quoted

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

On 17/05/2023 11:41, Claudiu Beznea wrote:

quoted

Convert Atmel PMC documentation to yaml. Along with it clock names
were adapted according to the current available device trees as
different controller versions accept different clock (some of them
have 3 clocks as input, some has 2 clocks as inputs and some with 2
input clocks uses different clock names).

Thank you for your patch. There is something to discuss/improve.

quoted

+
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - atmel,at91rm9200-pmc
+              - atmel,at91sam9260-pmc
+              - atmel,at91sam9g20-pmc
+    then:
+      properties:
+        clocks:
+          minItems: 2
+          maxItems: 2
+        clock-names:
+          items:
+            - const: slow_xtal
+            - const: main_xtal
+
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - atmel,sama5d2-pmc
+              - atmel,sama5d3-pmc
+              - atmel,sama5d4-pmc
+    then:
+      properties:
+        clocks:
+          minItems: 2
+          maxItems: 2
+        clock-names:
+          items:
+            - const: slow_clk
+            - const: main_xtal

This and previous if, should be squashed. You have exactly the same then:.

Clock names are different. Or do you propose to have a if for
clocks:
  minItems: 2
  maxItems: 2

and 2 ifs for clock names?

Ah, I see, they have different names - xtal -> clk.

Reviewed-by: Krzysztof Kozlowski <redacted>


Best regards,
Krzysztof