Re: [PATCH v2 6/6] riscv: dts: allwinner: d1: Add SPI0 controller node
From: Andre Przywara <andre.przywara@arm.com>
Date: 2023-05-06 22:00:53
Also in:
linux-arm-kernel, linux-riscv, linux-spi, linux-sunxi, lkml
On Sat, 6 May 2023 10:30:14 +0300 Maksim Kiselev [off-list ref] wrote: Hi,
quoted hunk ↗ jump to hunk
Some boards form the MangoPi family (MQ\MQ-Dual\MQ-R) may have an optional SPI flash that connects to the SPI0 controller. This controller is the same for R329/D1/R528/T113s SoCs and should be supported by the sun50i-r329-spi driver. So let's add its DT node. Signed-off-by: Maksim Kiselev <redacted> --- .../boot/dts/allwinner/sunxi-d1s-t113.dtsi | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+)diff --git a/arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi b/arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi index 922e8e0e2c09..a52999240a8e 100644 --- a/arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi +++ b/arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi@@ -108,6 +108,12 @@ rmii_pe_pins: rmii-pe-pins { function = "emac"; }; + /omit-if-no-ref/ + spi0_pins: spi0-pins { + pins = "PC2", "PC3", "PC4", "PC5"; + function = "spi0"; + }; + /omit-if-no-ref/ uart1_pg6_pins: uart1-pg6-pins { pins = "PG6", "PG7";@@ -447,6 +453,21 @@ mmc2: mmc@4022000 { #size-cells = <0>; }; + spi0: spi@4025000 { + compatible = "allwinner,sun20i-d1-spi", + "allwinner,sun50i-r329-spi"; + reg = <0x04025000 0x300>;
The manual (and the other DTs) use 4K, so please use that here as well.
+ interrupts = <SOC_PERIPHERAL_IRQ(15) IRQ_TYPE_LEVEL_HIGH>; + clocks = <&ccu CLK_BUS_SPI0>, <&ccu CLK_SPI0>; + clock-names = "ahb", "mod"; + dmas = <&dma 22>, <&dma 22>; + dma-names = "rx", "tx"; + resets = <&ccu RST_BUS_SPI0>; + status = "disabled"; + #address-cells = <1>; + #size-cells = <0>; + };
I think we should add the second SPI controller here as well, using that DBI fallback compatible string. Above looks correct when compared to the manual. Thanks, Andre
+
usb_otg: usb@4100000 {
compatible = "allwinner,sun20i-d1-musb",
"allwinner,sun8i-a33-musb";