Thread (2 messages) 2 messages, 2 authors, 2023-04-06

Re: [PATCH v2 2/5] dt-bindings: arm: msm: Add bindings for multi channel DDR in LLCC

flat view

From: Krzysztof Kozlowski <hidden>
Date: 2023-04-06 09:35:02
Also in: linux-arm-msm, lkml

On 06/04/2023 11:19, Komal Bajaj wrote:
quoted
quoted
quoted
  
    interrupts:
      maxItems: 1
  
+  multi-ch-bit-off:
+    items:
+      - description: Specifies the offset in bits into the multi_channel_register
+                     and the number of bits used to decide which LLCC configuration
+                     to use
There are here few issues.
First, I don't fully understand the property. What is an LLCC
configuration? Like some fused values?
There are different configuration for LLCC based on the number of
DDR channel it uses. Here, we are basically trying to get information
about the same.
quoted
quoted
Second, don't make it a register specific, it will not scale easily to
any new version of this interface. Although how this should look like
depends on what is it.
LLCC driver can only get DDR channel information from the register.
And why would that exactly matter to DT? How does it solve my concern
that your approach does not scale?

Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help