Re: [PATCH v3 14/17] arm64: dts: mediatek: add OPP support for mt8365 SoC
From: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Date: 2023-03-29 13:28:34
Also in:
linux-arm-kernel, linux-gpio, linux-mediatek, linux-mmc, linux-watchdog, lkml
Il 29/03/23 10:54, Alexandre Mergnat ha scritto:
quoted hunk ↗ jump to hunk
In order to have cpufreq support, this patch adds generic Operating Performance Points support. Signed-off-by: Alexandre Mergnat <redacted> --- arch/arm64/boot/dts/mediatek/mt8365.dtsi | 85 ++++++++++++++++++++++++++++++++ 1 file changed, 85 insertions(+)diff --git a/arch/arm64/boot/dts/mediatek/mt8365.dtsi b/arch/arm64/boot/dts/mediatek/mt8365.dtsi index 394a5a61be59..c3ea3cc97a47 100644 --- a/arch/arm64/boot/dts/mediatek/mt8365.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8365.dtsi@@ -20,6 +20,75 @@ cpus { #address-cells = <1>; #size-cells = <0>; + cluster0_opp: opp-table-0 { + compatible = "operating-points-v2"; + opp-shared;
One blank line here please, makes it slightly more readable.
+ opp-850000000 {
+ opp-hz = /bits/ 64 <850000000>;
+ opp-microvolt = <650000>;
+ };Also, my personal preference is to also leave a blank line between each opp-xxxx subnode, but that's your choice. Everything else looks good.