Thread (89 messages) 89 messages, 10 authors, 2023-03-21

Re: [PATCH 00/15] Introduce Nuvoton ma35d1 SoC

From: "Arnd Bergmann" <arnd@arndb.de>
Date: 2023-03-18 09:08:37
Also in: linux-clk, linux-serial, lkml

On Sat, Mar 18, 2023, at 04:07, Jacky Huang wrote:
On 2023/3/18 上午 12:06, Krzysztof Kozlowski wrote:
quoted
On 17/03/2023 14:21, Arnd Bergmann wrote:
quoted
I only now saw that you had already submitted this several times
at the beginning of last year, and this is technically 'v5'
of the series, and it would make sense to add 'v6' to the subject
next time and link back to the previous [1] and this[2] submission
on lore.kernel.org.
... and address previous feedback. Or at least make it clear in
changelog that you addressed it, so our review was not ignored.
Of course, I will add back the changelog.

And, I have a question. If subsequent modifications made to a patch, 
should the

"Reviewed-by" still be valid? Can we keep it?
In general yes, but it's a bit of a grey area and you have
to apply common sense. Examples where I would drop the
Reviewed-by tag are

- if you changed something based on feedback from a reviewer and
  they provided a Reviewed-by tag based on that changed, but then
  another person asked you change the same thing differently, or
  back to the original version

- if you combine a patch with another one that was not also
  reviewed by the same person.

      Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help