Re: [PATCH v3 1/2] of: create of_root if no dtb provided

From
Frank Rowand <hidden>
Date
2023-03-01 16:49:22
Also in
lkml
Reply to
Rob Herring, 2023-03-01
On 2/28/23 21:00, Rob Herring wrote:
On Tue, Feb 28, 2023 at 08:05:58PM -0600, Frank Rowand wrote:
quoted
On 2/27/23 11:17, Rob Herring wrote:
quoted
On Thu, Feb 23, 2023 at 3:34 PM Frank Rowand [off-list ref] wrote:
quoted
When enabling CONFIG_OF on a platform where of_root is not populated by
firmware, we end up without a root node. In order to apply overlays and
create subnodes of the root node, we need one. Create this root node
by unflattening an empty builtin dtb.

If firmware provides a flattened device tree (FDT) then the FDT is
unflattened via setup_arch().  Otherwise, setup_of() which is called
immediately after setup_arch(), and will create the default root node
if it does not exist.
Why do we need a hook after setup_arch() rather than an initcall?

Rob
It might work as an initcall today.  Maybe not in the future as other
initcalls are added.
That's an argument for never using initcalls (not a bad one either). But 
we have them and we have little reason not to use them. Also, it's 
better to do things as late as possible I've found. The earlier you do 
things, the more architecture specific stuff you hit. That's a big 
reason for the remaining differences in FDT init across architectures. 
Maybe after setup_arch is late enough. IDK.
quoted
But my main stream of thinking is that before the patch "we know" that
the device tree data structure exists when setup_arch() returns.
Adding setup_of() immediately after setup_arch() retains that
guarantee, but one line later in start_kernel().
I get the logic. I'd just rather not add another hook between the DT 
code and the core/arch code. Especially for this niche usecase.

We already have the secondary init when sysfs is up. Can't we just do 
this there?
In general, I agree with your sentiments about an initcall being a preferred
solution.

But when I was looking at the suggested alternatives, I noticed one sticking
point.  The new setup_of() calls unflatten_device_tree(), which calls
unittest_unflatten_overlay_base().  The call to unittest_unflatten_overlay_base()
is deliberately very early in the boot, so that the memory allocator used
for this very small portion of the devicetree nodes created for unittest
is the same early boot allocator that is used to unflatten an FDT passed
to the kernel from a bootloader.

Digging through this led me to another issue.  I have not tested this patch
series on a user mode linux kernel (on my todo list...).  For user mode linux,
unittest_data_add() is called directly from the late initcall of_unittest().
So for user mode linux, unittest_data_add() will be called a second time - I
need to remove that second call and make sure unittest still works on user
mode linux.
quoted
I could have instead put the call to setup_of() into each architectures'
setup_arch(), but that would just be duplicating the same code for each
architecture, which did not seem like a good choice.
Uhh, no!
Agreed, I guess I was too subtle with "did not seem like a good choice". :-)
Rob
  
Thread (9 messages) 9 messages, 4 authors, last reply 2023-03-01
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help