Re: [PATCH v2 3/5] dt-bindings: hwlock: sun6i: Add missing names
From: Andre Przywara <andre.przywara@arm.com>
Date: 2023-02-15 20:51:49
Also in:
linux-arm-kernel, linux-remoteproc, linux-sunxi, lkml
On Wed, 15 Feb 2023 21:37:08 +0100 Bastian Germann [off-list ref] wrote:
The allwinner,sun6i-a31-hwspinlock.yaml binding needs clock-names and reset-names set to "ahb" as required by the Linux driver.
Mmmh, but I thought that Krzysztof pretty clearly NAKed this? So we have to either reach consensus on this or find another solution, like teaching the driver to comply with the existing binding. We could for instance get the first clock, should the devm_clk_get() call fail. Cheers, Andre
quoted hunk ↗ jump to hunk
Fixes: f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock") Signed-off-by: Bastian Germann <redacted> --- .../hwlock/allwinner,sun6i-a31-hwspinlock.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+)diff --git a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml index 38478dad8b25..6cdfe22deb3c 100644 --- a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml +++ b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml@@ -23,9 +23,17 @@ properties: clocks: maxItems: 1 + clock-names: + items: + - const: ahb + resets: maxItems: 1 + reset-names: + items: + - const: ahb + '#hwlock-cells': const: 1@@ -33,7 +41,9 @@ required: - compatible - reg - clocks + - clock-names - resets + - reset-names - "#hwlock-cells" additionalProperties: false@@ -47,7 +57,9 @@ examples: compatible = "allwinner,sun6i-a31-hwspinlock"; reg = <0x01c18000 0x1000>; clocks = <&ccu CLK_BUS_SPINLOCK>; + clock-names = "ahb"; resets = <&ccu RST_BUS_SPINLOCK>; + reset-names = "ahb"; #hwlock-cells = <1>; }; ...